Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added name checking to new colorramps as well #218

Closed
wants to merge 2 commits into from
Closed

added name checking to new colorramps as well #218

wants to merge 2 commits into from

Conversation

tecoholic
Copy link
Contributor

Previously color ramps when created with the same name were being replaced without warning in the style manager. This commit adds the warning dialogs.

@etiennesky
Copy link
Contributor

committed your fir fix, but not second as it's unrelated to subject - plus I pushed first fix before you added second. I''l look into second

@tecoholic
Copy link
Contributor Author

Actually I meant the second commit for @NathanW2 I wanted to make it a seperate pull request. Github just auto added when I pressed pull request, I think ;)

@NathanW2
Copy link
Member

@etiennesky can you commit the other one for me.

@etiennesky
Copy link
Contributor

@tecoholic - that's the problem with github pull requests... I found that the easiest way to separate commits in different pull requests is to have separate branches for each request.

@NathanW2 - I am adding some comments to the ticket

@etiennesky
Copy link
Contributor

@tecoholic clicking on a symbol (fill style) when in the layer properties dialog crashes qgis, this doesn't happen in the style manager.

Can you fix that?

Program received signal SIGSEGV, Segmentation fault.
0x000000000054017a in QListData::size (this=0x10) at /usr/include/qt4/QtCore/qlist.h:98
98 inline int size() const { return d->end - d->begin; }
(gdb) bt
#0 0x000000000054017a in QListData::size (this=0x10) at /usr/include/qt4/QtCore/qlist.h:98
#1 0x00007ffff4649b98 in QList<QgsSymbolLayerV2*>::count (this=0x10) at /usr/include/qt4/QtCore/qlist.h:280
#2 0x00007ffff4660c58 in QgsSymbolV2::symbolLayerCount (this=0x0) at /data/src/qgis/qgis-master/src/core/symbology-ng/qgssymbolv2.h:77
#3 0x00007ffff4096304 in QgsSymbolsListWidget::setSymbolFromStyle (this=0x2dcc1f0, index=...) at /data/src/qgis/qgis-master/src/gui/symbology-ng/qgssymbolslistwidget.cpp:306
#4 0x00007ffff4152b67 in QgsSymbolsListWidget::qt_static_metacall (_o=0x2dcc1f0, _c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7fffffff9290)
at /data/src/qgis/qgis-master/build-debug/src/gui/symbology-ng/moc_qgssymbolslistwidget.cxx:72

@tecoholic
Copy link
Contributor Author

Sorry for the buggy commit. discard this thing. I have found some more GUI things that need to be fixed. I fix them and send a new request outlining the fixes.

@tecoholic tecoholic closed this Aug 28, 2012
yjacolin pushed a commit to yjacolin/QGIS that referenced this pull request Oct 4, 2014
Copyediting review through working_with_gps
@qgib qgib mentioned this pull request May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants