Fixing bug #8218 #702
Closed
Fixing bug #8218 #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For you commit messages the best thing to use is just: "Fix #bugnumber" that will auto close the ticket. |
|
Thank you for the tip. I will do it in future fixes. |
|
This pull request is a little messy with all the reverts and merges. Could you create a new branch with commit for each fix. Remember to use "Fix #issueno" as your message. You don't have to redo your work. Create a branch from origin/master and cherry-pick your commits over. git checkout -b bugfixes origin/mater
git cherry-pick a7c8b94 -edit
git cherry-pick d2b85cb -edit
git cherry-pick abbc250 -editusing Create a new pull request on that branch once you have done that. |
Closed
This was referenced May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Bug#8218 http://hub.qgis.org/issues/8218