Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using rich editor for content, check data validity #42

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Oct 30, 2023

Please find below a screenshot of the feed item form after improvement:

Screenshot 2023-10-30 at 10 52 45 AM

@dimasciput
Copy link
Collaborator

Thanks, @Xpirix, could you create a GIF or web video instead of a screenshot, so I can see it in action?

@Xpirix
Copy link
Collaborator Author

Xpirix commented Oct 30, 2023

@dimasciput Please find below a GIF for the rich editor. I will also send the validity check
Improve-form-edit

@Xpirix
Copy link
Collaborator Author

Xpirix commented Oct 30, 2023

@dimasciput Please find below a GIF for the data validity check.
Improve-form

@Xpirix
Copy link
Collaborator Author

Xpirix commented Oct 30, 2023

@dimasciput Please find below a GIF for the submit button. It's disabled when Required fields are empty or URL is not valid.
Improve-form-button

Copy link
Collaborator

@dimasciput dimasciput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimasciput dimasciput merged commit b023198 into qgis:master Oct 31, 2023
2 checks passed
@Xpirix Xpirix deleted the form_improvment branch October 31, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants