-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content char counter, improve invalid form handling #59
Conversation
Looks good to me from your specifications and screen cast 👍 Thanks ! |
qgisfeedproject/qgisfeed/views.py
Outdated
@@ -268,12 +268,19 @@ def get(self, request): | |||
user_is_approver = user.has_perm("qgisfeed.publish_qgisfeedentry") | |||
form = self.form_class() | |||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xpirix, could you please create a function for this? That way, you won't need to call it every time. Alos please create a test for the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check my comment
@dimasciput , I've made the changes. |
This PR has been deployed. |
Changes summary
content
value including HTML tags.Submit for review
/Save changes
/Approve and publish
when the form is not valid (including content field max characters exceeded)Please find bellow a GIF demonstrating these changes: