Add content char counter, improve invalid form handling #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me from your specifications and screen cast 👍 Thanks ! |
dimasciput
reviewed
Jan 3, 2024
qgisfeedproject/qgisfeed/views.py
Outdated
| @@ -268,12 +268,19 @@ def get(self, request): | |||
| user_is_approver = user.has_perm("qgisfeed.publish_qgisfeedentry") | |||
| form = self.form_class() | |||
|
|
|||
| try: | |||
There was a problem hiding this comment.
@Xpirix, could you please create a function for this? That way, you won't need to call it every time. Alos please create a test for the function.
|
@dimasciput , I've made the changes. |
dimasciput
approved these changes
Jan 4, 2024
|
This PR has been deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes summary
contentvalue including HTML tags.Submit for review/Save changes/Approve and publishwhen the form is not valid (including content field max characters exceeded)Please find bellow a GIF demonstrating these changes: