Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a field to specify reviewers when submitting a new feed item #62

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Dec 20, 2023

Changes summary

  • Implement chosen script and styles
  • Add a new field Reviewers on the new feed item form
  • The author can choose one or multiple reviewers
  • If at least one reviewer is specified, set the specified reviewers as recipients and cc the other reviewers. Otherwise, set all reviewers as recipients of the email.

Requirements

  • Only superusers and users with the group permission qgisfeedentry_approver can review a feed item
  • We should ensure that the variables for email sending are configured correctly on the server side

Please find below a GIF demonstrating the new field:
Select reviewers

Please find below a screenshot of the email for reviewers:
Screenshot 2023-12-20 at 2 06 38 PM

Copy link
Member

@haubourg haubourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's perfect to me 👍

@dimasciput
Copy link
Collaborator

@Xpirix looks good, but please could you add test for this. Thanks.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Jan 3, 2024

My pleasure. I've added the test for this.

@dimasciput
Copy link
Collaborator

@Xpirix LGTM, please fix the conflicts

@Xpirix
Copy link
Collaborator Author

Xpirix commented Jan 4, 2024

@dimasciput , The conflicts are fixed.

@dimasciput dimasciput merged commit dd0a766 into qgis:master Jan 22, 2024
2 checks passed
@Xpirix Xpirix deleted the specify_reviewers branch January 22, 2024 11:40
@Xpirix
Copy link
Collaborator Author

Xpirix commented Jan 30, 2024

This PR has been deployed. The email sending will not work yet. We will set up the variables to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants