Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule-based style visibility messed up #710

Closed
Jeroen-GroeneBij opened this issue Feb 11, 2019 · 6 comments
Closed

rule-based style visibility messed up #710

Jeroen-GroeneBij opened this issue Feb 11, 2019 · 6 comments
Labels

Comments

@Jeroen-GroeneBij
Copy link

Using gqis 3.4.4. and qgis2web 3.4.0 I am having troubles with rule-based styling.
Building the the exact same project in qgis 2.18.28 and qgis2web 2.34.0 works perfect.
Opening the 2.18 project within 3.4 doesn't show improvement and rules out a mistake in building the project directly in 3.4.

The preview and the export shows just one colour, in stead of all 5 colours used in the rule-based styling.
I usually build a rule based styling starting with a gradual based style, then changing it to rule-based and editing the rules (in stead of writing the entire rule and make a typo).

I have attached the qgis files and the export files. I haven't found the style file. I can save it in qgis3, but I do not know where it is saved (2.18 let's me choose where to save the .qml file)

VVM.zip
qgis2web_2019_02_11-12_10_47_442719.zip

@Jeroen-GroeneBij Jeroen-GroeneBij changed the title rule-based style visisble messed up rule-based style visibility messed up Feb 11, 2019
@tomchadwin
Copy link
Collaborator

Confirmed - investigating.

@tomchadwin tomchadwin added the bug label Feb 11, 2019
tomchadwin added a commit that referenced this issue Feb 11, 2019
@tomchadwin
Copy link
Collaborator

Are you able to download the master branch from here? I've made a fix which sorts out the problem for me. Let us know.

@Jeroen-GroeneBij
Copy link
Author

This seems to work, at least for this project. I haven't tested it yet on more complex projects
I did notice two things:

  1. since my qgis version still opens the export in IE: it didn't show in IE, it gave a 404 ( but I don't remember if the 'formal version' did show something in IE, I think it was a blank page.
    Opening the export in Firefox does show the map as it is intended.
  2. There is a large amount of 'python warnings' in the message-log, all related to qgis2web.

@tomchadwin
Copy link
Collaborator

  1. Discussed in qgis2web opens in IE #709
  2. If you can paste some of the warning here (as a new issue), I can look into them - without them, I'm in the dark

@tomchadwin
Copy link
Collaborator

Thanks for testing and confirming the other fix, by the way. Very much appreciated.

@tomchadwin
Copy link
Collaborator

Released as 3.5.0 and pushed to QGIS plugins repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants