Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1 #1

Closed
wants to merge 13 commits into from
Closed

V1 #1

wants to merge 13 commits into from

Conversation

qhwa
Copy link
Owner

@qhwa qhwa commented Oct 25, 2019

What is implemented?

  • importing products from a CSV file
  • basic UI feedback
    • successful imported, and the number is displayed
    • none will be imported from an empty CSV file
    • none will be imported from a invalid CSV format
  • tests
    • unit tests
    • controller tests

What is not implemented? (Further developing ideas)

  • cleanup the unused APIs and tests created on Phoenix initialization.
  • Transactions. What if some insertions fail during the execution?
  • CSV validating. There are duplicated part_number rows in test/fixtures/data.csv. In most cases, this would be a manual mistake. Should we reject it?
  • Allow users to delete products not presented in the CSV, as the task mentioned. Maybe I can implement it as follows:
    • import products as present
    • select all unique part_number in the CSV
    • delete all products not in part_numbers above
  • UI tests
  • credo for linting
  • CI config (maybe overkill for this project but can't live without it. I used git hooks locally.)

@qhwa qhwa closed this Jul 6, 2020
@qhwa qhwa mentioned this pull request Jul 6, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant