Add index.d.ts with Typescript types #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update package.json to reference the index.d.ts file with Typescript types. Providing types with the package makes using the package more natural for folks working in typescript projects.
|
Any desire to merge this? |
|
@qiao ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update package.json to reference the index.d.ts file with Typescript types. Providing types with the package makes using the package more natural for folks working in typescript projects.
I've copied the types from DefinitelyTyped as a starting point. Once this is merged, the types can be removed from DefinitelyTyped since the package will ship with the types itself.