-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests #11
Conversation
I know that debugging workflows is frustrating, but helpful commit messages are always useful... Moreover, in principle it could be possible to even debug locally (unofficial): |
Btw, the one failing was the docs workflow (that should not be involved here). The one being fixed is not even running, because of the missing secret... |
@alecandido @BrunoLiegiBastonLiegi could you please have a look at the CI please? |
mmmh I am trying to run the tests locally but
|
The correct port is definitely 8080 (despite 80 being the default in E AssertionError: Local Qibo package version does not match the server one, please upgrade: 0.2.5-> 0.2.4 (btw, I don't have a valid token to test, but the version check seems to happen before that) |
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
@alecandido @BrunoLiegiBastonLiegi please have another look, this is probably ready. We have already in |
This looks ready to me. Should we add in the documentation a reminder about setting port One other thing that I think we should do is making |
I'd say that there is no point in having the wrong port configured in |
@@ -18,6 +20,7 @@ class QiboClientBackend(NumpyBackend): | |||
|
|||
def __init__(self, token, provider=None, platform=None): | |||
super().__init__() | |||
os.environ.setdefault("QRCCLUSTER_PORT", "8080") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's also fine, for the time being. But the proper place will be:
https://github.com/qiboteam/qibo-client/blob/4e70c049bb66475d9af468fe3e9611d75fd5e5fb/src/qibo_client/tii.py#L6
since providers are defined there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok I see, makes sense. By the way, for some reason if you set the env variable inside the backend it won't be set correctly inside of the test, but I am not sure why...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm now checking it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error found: the environment is probed top-level, both in qibo-cloud-backends
and qibo-client
, thus it is determined at import
time, and insensitive to updates.
This is a problem in different ways, I will file one issue per repo describing it. The hotfix is in c922218, and just reverts what you did.
I guess this was related to qiboteam/qibo-client#21 |
Assign default value for tokens
My suggestion is to keep the code here port independent or at least do not hard code 8080 anywhere. We are planning to move from 8080 to 80 soon in this month. |
We could move the port setting to the test (I thought it was already, but I was wrong) EDIT: I saw #11 (comment) only after writing, I actually moved to the workflow |
Perfect @alecandido, thanks! |
Since it is now allowed by qibo-client v0.0.3
Use secrets to make tests run.