Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pip extras #1252

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Introduce pip extras #1252

merged 3 commits into from
Mar 8, 2024

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Mar 7, 2024

Closes #1251

They were obviously missing when the dependencies have been made optional.

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d1fe5a9) to head (bb1a137).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1252   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files          72       72           
  Lines       10454    10454           
=======================================
  Hits        10449    10449           
  Misses          5        5           
Flag Coverage Δ
unittests 99.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alecandido. I cannot tell anything about nix but confirmed that tensorflow is no longer installed by default in this branch.

@alecandido
Copy link
Member Author

Currently, I'm the only one using Nix (though it's there for everyone, and you could have a reproducible shell).
However, the baseline is that I'm updating that as well, to avoid outdated content in our repo, but the core of the PR is just Poetry.

@alecandido alecandido added this pull request to the merge queue Mar 8, 2024
Merged via the queue into master with commit bbae1aa Mar 8, 2024
21 checks passed
@alecandido alecandido deleted the optional-deps branch March 8, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tensorflow dependency
3 participants