Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on_qubits with set_parameters #642

Merged
merged 2 commits into from Sep 13, 2022
Merged

Fix on_qubits with set_parameters #642

merged 2 commits into from Sep 13, 2022

Conversation

stavros11
Copy link
Member

Fixes #641.

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (375b7e4) compared to base (746be95).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #642   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines        10429     10451   +22     
=========================================
+ Hits         10429     10451   +22     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/gates/abstract.py 100.00% <100.00%> (ø)
src/qibo/gates/gates.py 100.00% <100.00%> (ø)
src/qibo/tests/test_models_circuit_parametrized.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stavros11 thanks!

@scarrazza
Copy link
Member

@renatomello could you please test this by installing the following wheel with (after decompressing):
pip install qibo-0.1.9.dev0-py3-none-any.whl

@renatomello
Copy link
Contributor

It works, thanks very much.

@scarrazza scarrazza merged commit 14add5a into master Sep 13, 2022
@stavros11 stavros11 deleted the lightconeparams branch September 14, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circuit.light_cone() resets phases of parametrized gates
3 participants