[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/psf/black: 22.8.0 → 22.10.0
• github.com/asottile/pyupgrade: v2.38.2 → v3.1.0

[codecov]

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a7076f3) compared to base (3a48025).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff            @@
##            master      #656   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines        10531     10530    -1     
=========================================
- Hits         10531     10530    -1     

Flag	Coverage Δ
unittests	100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/qibo/optimizers.py	100.00% <ø> (ø)
src/qibo/gates/gates.py	100.00% <100.00%> (ø)
src/qibo/gates/special.py	100.00% <100.00%> (ø)
src/qibo/models/circuit.py	100.00% <100.00%> (ø)
src/qibo/models/evolution.py	100.00% <100.00%> (ø)
src/qibo/models/grover.py	100.00% <100.00%> (ø)
src/qibo/models/qgan.py	100.00% <100.00%> (ø)
src/qibo/models/variational.py	100.00% <100.00%> (ø)
src/qibo/tests/test_models_evolution.py	100.00% <100.00%> (ø)
src/qibo/tests/test_prints.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alecandido]

Problem here is the following:

https://github.com/asottile/pyupgrade/blob/d50ce21fc45d014790d4ecf71d1b1d7ccc450526/README.md#-coding--comment

# coding: ... comment

as of PEP 3120, the default encoding for python source is UTF-8

-# coding: utf-8
 x = 1

So it is clashing with:

qibo/.pre-commit-config.yaml

Line 11 in da4ed92

- id: fix-encoding-pragma

Proposed solution

1. drop pragmas and fix-encoding-pragma hook
2. revert pyupgrade upgrade

In the second case, the offending commit is asottile/pyupgrade@57eb8ab, not surprisingly a very big one, and exactly the one before v3.0.0.
So, it should be reverted to v2.x.y (the latest of the series being v2.38.4).

[scarrazza]

@alecandido thank you so much. @andrea-pasquale could you please have a look?

[felixhekhorn]

Sorry for jumping in, but I believe there is even a third possibility: i.e. configure the hook as it should be able to even remove pragmas: https://github.com/pre-commit/pre-commit-hooks/blob/5420c705a4dda45ce7edb2a570b8d3f64e3648eb/pre_commit_hooks/fix_encoding_pragma.py#L123

[alecandido]

Sorry for jumping in, but I believe there is even a third possibility: i.e. configure the hook as it should be able to even remove pragmas: https://github.com/pre-commit/pre-commit-hooks/blob/5420c705a4dda45ce7edb2a570b8d3f64e3648eb/pre_commit_hooks/fix_encoding_pragma.py#L123

That is not very useful, since the clash is there because pyupgrade is already doing it. Better to keep a single dependency, rather than two doing the same job (for as long as they actually do the same...).

[andrea-pasquale]

Thanks @alecandido and @felixhekhorn.
@scarrazza I think that the safest solution is this one

2. revert pyupgrade upgrade

If you agree I'll implement this fix here.

[scarrazza]

Thanks guys @felixhekhorn @alecandido. @andrea-pasquale I agree with the downgrade.

[andrea-pasquale]

Done @scarrazza. Now tests are passing. Feel free to merge.

[scarrazza]

Thank you all.