updating poetry lock and toml #294
Conversation
pyproject.toml
Outdated
| python = ">=3.8, <4" | ||
| qibolab = "^0.0.1" | ||
| python = ">=3.8,<3.12" | ||
| qibolab = "^0.0" |
There was a problem hiding this comment.
Just for personal understanding: you suppressed the .1 because it would have been incompatible with .2, isn't it?
There was a problem hiding this comment.
Yeah, for this I don't have a strong opinion, we could simply set ^0.0.2 and then update version by version.
However, qibocal seems not compatible with qibo 0.1.12 (the <4 was locking the upgrade in the workflow). @andrea-pasquale are you aware of this problem (see failing tests below)?
There was a problem hiding this comment.
Yeah, for this I don't have a strong opinion, we could simply set
^0.0.2and then update version by version.
As soon as possible, we should simply start using versions >0.1.0, and the problem will be partially solved.
With 0.x.y you only have the MAJOR+MINOR equivalent, and you lose the PATCH number. But with 0.0.x there is only MAJOR, and it is quite inconvenient...
There was a problem hiding this comment.
However, qibocal seems not compatible with qibo 0.1.12 (the
<4was locking the upgrade in the workflow). @andrea-pasquale are you aware of this problem (see failing tests below)?
I think that the problem is related to the function copy_circuit that @wilkensJ introduced in the rb module.
@Edoardo-Pedicillo already fixed this issue in #288 which was merged in #266. As soon as we merge #266 to main and we merge main here tests should pass.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 37.84% 37.84%
=======================================
Files 42 42
Lines 2801 2801
=======================================
Hits 1060 1060
Misses 1741 1741
Flags with carried forward coverage won't be shown. Click here to find out more. |
Updating to latest qibo 0.1.12.
Checklist: