-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing to_dict
in property
#299
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 37.84% 37.84%
=======================================
Files 42 42
Lines 2801 2801
=======================================
Hits 1060 1060
Misses 1741 1741
Flags with carried forward coverage won't be shown. Click here to find out more. |
I manage to test on qblox the majority of the routines (I am missing the ones involving sampling, two qubit gates and rb). |
I just tried it and it fixes the issue. If you want I can push those changes, the merge was without conflicts |
Thanks for the feedback @rodolfocarobene. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @andrea-pasquale
I confirm that it works with dummy. |
@stavros11 I would like to merge this but I'm not able to test it on QM since I don't know exactly what branch to use. I know that the runcard is in qiboteam/qibolab#349 and that you started from |
@andrea-pasquale I wanted to test it yesterday but unfortunately the QM went out and as far as I know we have not been able to connect to it yet. I am not sure when it will be back but at this stage we could merge this and qiboteam/qibolab#346 and if something breaks for QM I’ll fix it in one of my other open PRs in qibolab. |
Thanks. I'll proceed with the merge as soon as we merge qiboteam/qibolab#346. |
This PR needs to be merged as soon as we merge qiboteam/qibolab#346, which will change the
to_dict
method into the propertyraw
. This should resolve all issues related to the attributeaverage
of theto_dict
method.Checklist: