Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispersive shift plot #647

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Fix dispersive shift plot #647

merged 2 commits into from
Nov 29, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Nov 29, 2023

Closes #646.
There was a factor 1e9 wrong (possibly forgotten in #627)..

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #647 (c136ab4) into main (73ff1eb) will not change coverage.
Report is 4 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #647   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files         106      106           
  Lines        7338     7338           
=======================================
  Hits         7047     7047           
  Misses        291      291           
Flag Coverage Δ
unittests 96.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...cal/protocols/characterization/dispersive_shift.py 100.00% <ø> (ø)

Copy link

@JavierSerranoGarcia JavierSerranoGarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now works properly.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 9b307a4 Nov 29, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the fix_dispersive branch November 29, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem displaying dispersive shift
3 participants