Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qibotn integration to Qibo #24

Merged
merged 208 commits into from
Mar 1, 2024
Merged

Qibotn integration to Qibo #24

merged 208 commits into from
Mar 1, 2024

Conversation

Tankya2
Copy link
Contributor

@Tankya2 Tankya2 commented Feb 1, 2024

Addresses issue #7.
Qibotn (cuQuantum) is introduced as an additional backend to Qibo. Codes changes are made such that it follows the backend abstractions in Qibo. Runcard is used to configure the type of computation to be performed (either single node or multi node, dense vector or expectation calculation, an example can be found in the Readme).
This backend converts a given circuit to tensor network format and proceeds to do tensor contraction of the network for evaluation.

Tankya2 and others added 30 commits January 24, 2024 17:11
@Tankya2 @liweintu
add backend file
8e78420
@Tankya2 @liweintu
Added check for initial conditions
3f046be
@Tankya2 @liweintu
Added initial state for Quimb
2d48d3d
@Tankya2 @liweintu
Reverted back return_array to False
2a6b3a5
@Tankya2 @liweintu
Updates to include expectation calculation
0420cbf
@Tankya2 @liweintu
Format with black
37212a3
@liweintu
Add CPU and GPU into backends
b4b2fec
@liweintu
Finish CuTensorNet class for cuQuantum cutensornet
f8c2b88
@Tankya2
Rename function call
d3c9266
@Tankya2
Remove eval_tn_mpi
293af81
@Tankya2
Remove eval_tn_mpi
1035629
@Tankya2
Rename eval_tn_MPI_2 to eval_tn_MPI
66aaf0e
@Tankya2
Remove eval_tn_MPI_expectation
fea2b11
@Tankya2
Rename eval_tn_MPI_2_expectation to eval_tn_MPI_expectation
827c285
@Tankya2
Format with black
6181161
@Tankya2
Rename to better reflect function of file
44ac064
@Tankya2
Add condition to trigger expectation calculation
e112140
@Tankya2
Change import from cutn to eval [skip CI]
34125d1
@Tankya2
Rename function name to be more descriptive [skip CI]
93331aa
@Tankya2
Update function call name [skip CI]
391d252
@Tankya2
Change execute_circuit inputs
9ae7dc1
@Tankya2
Rename expectation function name
6216a32
@Tankya2
Use runcard to select compute type as no other way to pass in para wo…
1680185 
…ut changing struct
@Tankya2
Remove print [skip CI]
e7776f5
@Tankya2
Allow user to specify Pauli string pattern for expecation calculation…
9b8058d 
… [skip CI]
@Tankya2
Update to allow user to set MPS parameters and to set Pauli string pa…
a3f3538 
…ttern
@Tankya2
Remove backend
67fdafe
@Tankya2
Update sample code [skip CI]
d621eb2
@Tankya2
Update
83ffcfa
@Tankya2
Update sample codes
460f5e7
@yjmaxpayne yjmaxpayne mentioned this pull request Feb 17, 2024
Closed
alecandido
alecandido reviewed Feb 27, 2024
View reviewed changes
.github/workflows/rules.yml Outdated Show resolved Hide resolved
.github/workflows/rules.yml Outdated Show resolved Hide resolved
src/qibotn/eval_qu.py Outdated Show resolved Hide resolved
src/qibotn/backends/quimb.py Show resolved Hide resolved
tests/test_quimb_backend.py Outdated Show resolved Hide resolved
@alecandido
Copy link
Member

@Vinitha-balachandran whenever you do something, add the commit reference in the related conversation and mark it as resolved, please :)

@Vinitha-balachandran
Copy link
Contributor

@Vinitha-balachandran whenever you do something, add the commit reference in the related conversation and mark it as resolved, please :)

Sure. Will do next time.

@alecandido alecandido mentioned this pull request Feb 29, 2024
Merged
@alecandido alecandido self-requested a review March 1, 2024 09:27
alecandido
alecandido reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to postpone tests to a further PR?

alecandido
alecandido approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@alecandido alecandido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button, I wanted to approve.

(and postponing tests was a real question, and it's a sensible approach, since qibotn is not yet released and this PR is big enough)

@Tankya2 Tankya2 merged commit 371ec8d into main Mar 1, 2024
3 checks passed
@liweintu liweintu mentioned this pull request Mar 1, 2024
Closed
@alecandido alecandido deleted the qibotn_integration branch March 1, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinitha-balachandran Vinitha-balachandran Vinitha-balachandran left review comments

@liweintu liweintu liweintu approved these changes

@alecandido alecandido alecandido approved these changes

@scarrazza scarrazza Awaiting requested review from scarrazza

Assignees

@liweintu liweintu

@Tankya2 Tankya2

@Vinitha-balachandran Vinitha-balachandran

Labels
None yet
Projects
None yet
Milestone
QiboTN 0.0.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Tankya2 @alecandido @liweintu @Vinitha-balachandran @scarrazza @nitinshivaraman