support xml cdata node #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 42.63% 43.21% +0.57%
==========================================
Files 36 36
Lines 6382 6438 +56
==========================================
+ Hits 2721 2782 +61
+ Misses 3661 3656 -5
☔ View full report in Codecov by Sentry. |
qicosmos
reviewed
May 11, 2023
iguana/xml_reader.hpp
Outdated
| return cn; | ||
| } | ||
| } | ||
| std::cout << "cdata not found\n"; |
There was a problem hiding this comment.
应该是不需要了，我打算之后把错误处理都提出来，做个函数，不知道取什么名字
There was a problem hiding this comment.
以及现在代码没有全部覆盖，我晚上再完善一下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.