Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary code in json::parse_item<str> #164

Merged
merged 1 commit into from
May 15, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented May 15, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.32 🎉

Comparison is base (e1f20e2) 43.29% compared to head (a6e3f15) 43.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   43.29%   43.61%   +0.32%     
==========================================
  Files          36       36              
  Lines        6431     6472      +41     
==========================================
+ Hits         2784     2823      +39     
- Misses       3647     3649       +2     
Impacted Files Coverage Δ
iguana/json_reader.hpp 80.00% <ø> (+2.72%) ⬆️
test/unit_test.cpp 99.53% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qicosmos qicosmos merged commit 857bf02 into qicosmos:master May 15, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants