Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compile in gcc:release and support string_view to_json #168

Merged
merged 1 commit into from
May 18, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented May 18, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 18, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.04 🎉

Comparison is base (a1ff066) 43.74% compared to head (96331e0) 43.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   43.74%   43.78%   +0.04%     
==========================================
  Files          36       36              
  Lines        6502     6512      +10     
==========================================
+ Hits         2844     2851       +7     
- Misses       3658     3661       +3     
Impacted Files Coverage Δ
example/json_example.cpp 0.00% <0.00%> (ø)
iguana/json_writer.hpp 76.47% <100.00%> (+1.47%) ⬆️
iguana/xml_reader.hpp 100.00% <100.00%> (ø)
test/unit_test.cpp 99.56% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qicosmos qicosmos merged commit 4a329a7 into qicosmos:master May 18, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants