Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support parse yaml with comment and support THROW_UNKNOWN_KEY #178

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented Jun 25, 2023

  1. support THROW_UNKNOWN_KEY
  • Allow users to skip unnecessary objects
  1. full support yaml with comment
  • Before this, the comment after value could not be parsed correctly

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2023

Codecov Report

Patch coverage: 38.46% and project coverage change: +0.01 🎉

Comparison is base (66da579) 46.10% compared to head (50c4651) 46.12%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   46.10%   46.12%   +0.01%     
==========================================
  Files          41       42       +1     
  Lines        5897     5906       +9     
==========================================
+ Hits         2719     2724       +5     
- Misses       3178     3182       +4     
Impacted Files Coverage Δ
iguana/yaml_reader.hpp 100.00% <ø> (ø)
iguana/yaml_util.hpp 0.00% <0.00%> (ø)
test/test_yaml.cpp 100.00% <ø> (ø)
test/test_yaml_nothrow.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit 2b73fc6 into qicosmos:master Jun 26, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants