Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve json #198

Merged
merged 7 commits into from
Jul 21, 2023
Merged

Improve json #198

merged 7 commits into from
Jul 21, 2023

Conversation

qicosmos
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 18.94% and project coverage change: -0.43 ⚠️

Comparison is base (7f5ddb1) 42.63% compared to head (f42ed81) 42.21%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
- Coverage   42.63%   42.21%   -0.43%     
==========================================
  Files          44       45       +1     
  Lines        5270     5361      +91     
==========================================
+ Hits         2247     2263      +16     
- Misses       3023     3098      +75     
Impacted Files Coverage Δ
benchmark/json_benchmark.cpp 0.00% <ø> (ø)
benchmark/json_benchmark.h 0.00% <0.00%> (ø)
iguana/xml_reader.hpp 33.33% <ø> (ø)
test/test_headers.h 100.00% <ø> (ø)
iguana/json_reader.hpp 65.87% <5.55%> (-9.13%) ⬇️
iguana/json_util.hpp 23.07% <62.50%> (+0.34%) ⬆️
iguana/json_writer.hpp 100.00% <100.00%> (ø)
test/unit_test.cpp 99.63% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@qicosmos qicosmos merged commit ac7166d into master Jul 21, 2023
11 of 13 checks passed
@qicosmos qicosmos deleted the improve_json branch July 21, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants