Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support yaml 17 #209

Merged
merged 4 commits into from
Jul 31, 2023
Merged

support yaml 17 #209

merged 4 commits into from
Jul 31, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented Jul 30, 2023

YAML is supported in C++17; C++20 performance remains nearly unchanged. However, C++20 serialization outperforms C++17.

1690736531095
from left to right, it is: current repository, C++20 of PR , C++17 of PR.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: +0.20% 🎉

Comparison is base (4f81eeb) 43.70% compared to head (896cf64) 43.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   43.70%   43.91%   +0.20%     
==========================================
  Files          45       45              
  Lines        5343     5363      +20     
==========================================
+ Hits         2335     2355      +20     
  Misses       3008     3008              
Files Changed Coverage Δ
example/yaml_example.cpp 0.00% <ø> (ø)
iguana/yaml_util.hpp 0.00% <0.00%> (ø)
iguana/yaml_writer.hpp 100.00% <ø> (ø)
iguana/yaml_reader.hpp 100.00% <100.00%> (ø)
test/test_yaml.cpp 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbbgan bbbgan merged commit 37c363e into qicosmos:master Jul 31, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants