Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support int8_t; update README #210

Merged
merged 1 commit into from
Aug 1, 2023
Merged

support int8_t; update README #210

merged 1 commit into from
Aug 1, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented Jul 31, 2023

No description provided.

@qicosmos qicosmos self-requested a review August 1, 2023 01:49
@qicosmos
Copy link
Owner

qicosmos commented Aug 1, 2023

我担心这个处理会不会太特殊了?会破坏最初的语义?是否应该加一个宏,只有开启才这样处理会不会好点?

@bbbgan
Copy link
Collaborator Author

bbbgan commented Aug 1, 2023

没有吧,不会破坏什么,只是之前一直没注意

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10% 🎉

Comparison is base (37c363e) 43.91% compared to head (b1b8b82) 44.01%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #210      +/-   ##
==========================================
+ Coverage   43.91%   44.01%   +0.10%     
==========================================
  Files          45       45              
  Lines        5363     5373      +10     
==========================================
+ Hits         2355     2365      +10     
  Misses       3008     3008              
Files Changed Coverage Δ
iguana/detail/charconv.h 87.50% <100.00%> (+4.16%) ⬆️
test/unit_test.cpp 99.65% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbbgan bbbgan force-pushed the master branch 2 times, most recently from bbdfd65 to 79f019b Compare August 1, 2023 05:49
Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbbgan bbbgan merged commit 5a0617d into qicosmos:master Aug 1, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants