Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cpp17 #211

Merged
merged 1 commit into from
Aug 2, 2023
Merged

support cpp17 #211

merged 1 commit into from
Aug 2, 2023

Conversation

qicosmos
Copy link
Owner

@qicosmos qicosmos commented Aug 2, 2023

do some fix for cpp17.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 50.00% and project coverage change: +0.02% 🎉

Comparison is base (5a0617d) 44.01% compared to head (2aea53c) 44.03%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   44.01%   44.03%   +0.02%     
==========================================
  Files          45       45              
  Lines        5373     5375       +2     
==========================================
+ Hits         2365     2367       +2     
  Misses       3008     3008              
Files Changed Coverage Δ
iguana/json_util.hpp 25.92% <50.00%> (+5.92%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbbgan bbbgan self-requested a review August 2, 2023 09:55
@qicosmos qicosmos merged commit 441aa93 into master Aug 2, 2023
21 checks passed
@qicosmos qicosmos deleted the fix_for_cpp17 branch August 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants