Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix smart_ptr[json] #224

Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix smart_ptr[json] #224

merged 1 commit into from
Aug 30, 2023

Conversation

bbbgan
Copy link
Collaborator

@bbbgan bbbgan commented Aug 30, 2023

fix issue #223

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (1e8997c) 44.79% compared to head (049f216) 44.85%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   44.79%   44.85%   +0.05%     
==========================================
  Files          45       45              
  Lines        5449     5453       +4     
==========================================
+ Hits         2441     2446       +5     
+ Misses       3008     3007       -1     
Files Changed Coverage Δ
iguana/json_reader.hpp 88.99% <ø> (+0.80%) ⬆️
test/unit_test.cpp 99.68% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qicosmos qicosmos merged commit b2d39ac into qicosmos:master Aug 30, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants