New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make configuring baseURL easier and make the errors friendly #9
Conversation
I replaced the ugly if-statement with Map, and I also make the message user-friendly since this project is written for users, not only for developers. And also, I removed the useless "alert", it is useless and annoying for users.
首先,我把 此外,我把原本很醜的 最後,我把一些沒必要的 |
不如用.env文件?另外我准备将来将baseUrl存储到local storage,让使用者可以在设置页面自定义api url |
好呀!此外 API 的主要目的是取得網易雲音樂的資料,而各個 API 之間幾乎沒有差異,所以我覺得 API URL 沒有必要讓使用者設定。如果程式的 API 網址掛了,那應該是維護者去修,不應該讓使用者自己修;如果覺得 API 的速度太慢,那我不覺得使用者能找到與之版本匹配,其他區域的 API。 |
可自定义api url是出于隐私的考虑, 部分人会觉得用自己的api比较安心 |
其實我覺得真正會在乎隱私的,會選擇自己架設服務。我是建議等到有人開 Issues,有需求時再開發。 |
畢竟開發設定面板所花的時間,可能已經遠遠超過這功能所能帶來的效益。 |
设置页面还有其他的设置项,比如Light Mode/Dark Mode切换 |
聽起來不錯!那我覺得開發這功能尚算值得,期待你未來的更新 :) |
@qier222 那你打算 merge 這個 PR 嗎? |
First, I separate the
baseURL
option fromutils/request.js
.And, I replaced the ugly if-statement with Map, and I also make the message user-friendly since this project is written for users, not only for developers.
And also, I removed the useless "alert", it is useless and annoying for users.