Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Think about ProvDAG equality criteria #36

Open
ChrisKeefe opened this issue Dec 15, 2021 · 0 comments
Open

Think about ProvDAG equality criteria #36

ChrisKeefe opened this issue Dec 15, 2021 · 0 comments

Comments

@ChrisKeefe
Copy link
Collaborator

From inline notes

ProvDAG equality checks are currently based on class identity and graph isomorphism.

Is this a reasonable way to define ProvDAG equality? It doesn't take into account the equality of some ProvDAG attributes, but leans on DiGraph isomorphism.

Questions

Are two isomorphic ProvDAGs unequal if one was created without checksum validation?

How about if one has a checksum diff because it's been tinkered with?

If in the future we have a method that produces non-identical results from two identical DiGraphs based on _parsed_artifact_uuids, are those ProvDAGs still equal?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant