Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMP formats require Phred designation #301

Closed
nbokulich opened this issue Jul 6, 2018 · 2 comments
Closed

EMP formats require Phred designation #301

nbokulich opened this issue Jul 6, 2018 · 2 comments
Labels
type:bug Something is wrong.

Comments

@nbokulich
Copy link
Member

nbokulich commented Jul 6, 2018

Bug Description
Currently it looks like they assume Phred33 and does not check otherwise.

Screenshots
Importing Phred64 works, but makes a mess:

image

References
forum xref

@nbokulich nbokulich added the type:bug Something is wrong. label Jul 6, 2018
@gregcaporaso
Copy link
Member

We've never done anything about this because it's only possible to guess the Phred offset, as far as I know, e.g., based on frequency of characters. The user-provided offset would need to be validated during import (because we normalize to Phred 33 during import), and we'd have to have a way to override that check if the guess was wrong, and that's not something we can easily do while importing. While less than ideal to just not validate the user's Phred offset, the issue often becomes really obvious (as in the plot you shared) and Phred offset 64 data is really uncommon these days.

@nbokulich, do you think this is enough of an issue in practice that we should address it with some sort of check based on frequency of the characters?

@gregcaporaso gregcaporaso transferred this issue from qiime2/q2-demux Sep 19, 2023
@nbokulich
Copy link
Member Author

hey yeah we could close as phred64 is rare these days, though it still crops up (e.g., with re-use of old datasets)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something is wrong.
Projects
None yet
Development

No branches or pull requests

2 participants