Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSVTaxonomyFormat should check for empty column labels #181

Closed
thermokarst opened this issue May 31, 2018 · 4 comments
Closed

TSVTaxonomyFormat should check for empty column labels #181

thermokarst opened this issue May 31, 2018 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:bug Something is wrong.
Projects
2019.10

Comments

@thermokarst
Copy link
Contributor

The sniffer currently just checks for the presence header labels, but doesn't ensure that anything beyond the two record header labels are not empty strings.

This recently came up on the forum.
@thermokarst thermokarst added type:bug Something is wrong. help wanted Extra attention is needed good first issue Good for newcomers labels May 31, 2018
@turanoo
Copy link
Contributor

turanoo commented Feb 18, 2019

@thermokarst I'm interested in this. Can you assign me to this issue? Thanks

@thermokarst thermokarst added this to Backlog (Automated) in 2019.4 via automation Feb 18, 2019
@thermokarst
Copy link
Contributor Author

@turanoo --- it would be nice to update the sniff method referenced above to use the new _validate_ API (sniff has been deprecated). You can see an example of that process in #195.

@thermokarst thermokarst moved this from Backlog (Automated) to In Analysis in 2019.4 Apr 2, 2019
@thermokarst thermokarst added this to Backlog (Automated) in 2019.7 via automation May 14, 2019
@thermokarst thermokarst removed this from In Analysis in 2019.4 May 14, 2019
@jakereps
Copy link
Member

I can take a stab at this @thermokarst!

@David-Rod David-Rod mentioned this issue Jul 18, 2019
Merged
@thermokarst thermokarst removed this from Backlog (Automated) in 2019.7 Aug 2, 2019
@thermokarst thermokarst added this to In Progress - Supplanted Issues in 2019.10 Aug 2, 2019
@thermokarst
Copy link
Contributor Author

Fixed in #221

2019.10 automation moved this from In Progress - Supplanted Issues to Changelog Needed Oct 31, 2019
@thermokarst thermokarst moved this from Changelog Needed to Completed in 2019.10 Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed type:bug Something is wrong.
Projects
No open projects
2019.10
  
Completed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thermokarst @jakereps @turanoo