Skip to content
This repository has been archived by the owner on Dec 29, 2023. It is now read-only.

ENH: Specify source format during importing #75

Closed
thermokarst opened this issue Sep 7, 2016 · 4 comments
Closed

ENH: Specify source format during importing #75

thermokarst opened this issue Sep 7, 2016 · 4 comments
Assignees

Comments

@thermokarst
Copy link
Contributor

thermokarst commented Sep 7, 2016

q2cli users have the ability to specify the source_format when importing data, it would be great to have feature parity in q2studio.

See qiime2/q2cli#57 for more details on the q2cli implementation.

@ebolyen
Copy link
Member

ebolyen commented Sep 7, 2016

It would be great if there was a way to list transformations available for a directory format (and by proxy what formats could be used)

@thermokarst thermokarst changed the title Update import_data to support source format (a la q2cli) ENH: Specify source format during importing May 11, 2017
@maxvonhippel
Copy link
Contributor

maxvonhippel commented May 16, 2017

Working on this. EDIT: PR

@jairideout
Copy link
Member

Fixed in #111

@maxvonhippel
Copy link
Contributor

maxvonhippel commented May 18, 2017

If I put a BIOMV100Format file in a folder, select that directory when I click import to add an Artifact, and specify the source format as BIOMV100Format and the type as FeatureTable[Frequency], I get the error "BAD REQUEST - InPath('/home/qiime2/data') is not a file.

In comparison, if I repeat these steps with a folder containing a BIOMV210Format file named feature-table.biom and don't specify source format, everything works fine.

I see two possible issues here:

  1. The code doesn't seem to always detect the .biom files, even the V210 ones, in a directory, if they are not named according to some convention it likes.
  2. The code doesn't seem to be able to handle directory input for files which are not V210, such as V100 files.

Are these problems which should be fixed? If so, should we reopen this issue to address issue 2, and then create a new issue for issue 1, as above?

------- EDIT ------

I gave the wrong source format. For a directory with a single .biom file in it of BIOMV100Format I should give the source format of BIOMV100DirFmt. Similarly, a single file directory where the file is BIOMV210Format would require a source format of BIOMV210FirFmt. The error came because I told the code to expect a file and then gave it a directory ... which, obviously, isn't a file. The file naming convention is by design, not a mistake, and has to do with more complex situations in which we have to detect the correct file in a folder with many possible inputs, and pin down the precise reason behind any one of many possible errors that could happen. So there are no issues here and everything is awesome 👍 👍 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants