Skip to content

Commit

Permalink
addressing @charles-cowart comments
Browse files Browse the repository at this point in the history
  • Loading branch information
antgonza committed Dec 18, 2023
1 parent 4615dad commit 74d282f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ Version 2023.12

* The sample and preparation information pages will display the timestamp of their last update.
* Added a ProcessingJob.complete_processing_job method to retrieve the job that is completing the current job.
* Added a ProcessingJob.complete_processing_job method to retrieve the job that is completing the current job.
* Added a ProcessingJob.trace method to trace all the jobs of a processing_job.
* Analyses now accept SLURM reservation's via the GUI; this will be [helpful for workshops or classes](https://qiita.ucsd.edu/static/doc/html/faq.html#are-you-planning-a-workshop-or-class).
* Admins can now add per-user-level SLURM submission parameters via the DB; this is helpful to prioritize wet-lab and admin jobs.
Expand Down
2 changes: 0 additions & 2 deletions qiita_db/metadata_template/prep_template.py
Original file line number Diff line number Diff line change
Expand Up @@ -867,14 +867,12 @@ def _get_predecessors(workflow, node):
reqs_satisfied = True

if wk_params['sample']:
check_requirements = True
df = ST(self.study_id).to_dataframe(samples=list(self))
for k, v in wk_params['sample'].items():
if k not in df.columns or v not in df[k].unique():
reqs_satisfied = False

if wk_params['prep']:
check_requirements = True
df = self.to_dataframe()
for k, v in wk_params['prep'].items():
if k not in df.columns or v not in df[k].unique():
Expand Down

0 comments on commit 74d282f

Please sign in to comment.