-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #1987 #2047
Merged
Merged
fix #1987 #2047
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
-- Jan 15, 2017 | ||
-- Inherit the status of the study to all it's artifacts. | ||
-- This code is much easier using python so check that patch | ||
|
||
SELECT 1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
from qiita_db.study import Study | ||
|
||
|
||
class ForRecursion(object): | ||
"""for some strange reason, my guess is how we are executing the patches | ||
recursion doesn't work directly so decided to use a class to make it | ||
work""" | ||
|
||
@classmethod | ||
def change_status(cls, artifact, status): | ||
for a in artifact.children: | ||
try: | ||
a.visibility = status | ||
except: | ||
# print so we know which changes failed and we can deal by hand | ||
print "failed aid: %d, status %s" % (artifact.id, status) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Failed "aid?" Not sure I would understand what that was saying if I got this message. |
||
return | ||
cls.change_status(a, status) | ||
|
||
|
||
studies = Study.get_by_status('private').union( | ||
Study.get_by_status('public')).union(Study.get_by_status('sandbox')) | ||
# just getting the base artifacts, no parents | ||
artifacts = {a for s in studies for a in s.artifacts() if not a.parents} | ||
|
||
# inheriting status | ||
fr = ForRecursion | ||
for a in artifacts: | ||
status = a.visibility | ||
fr.change_status(a, status) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are facing the same issue that I was facing when doing the analysis refactor. Try changing this:
https://github.com/biocore/qiita/pull/2040/files#diff-694f6ed1529987bc3435746a74426405R408
then the functions should work