Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal fix for plugin testing #3193

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

antgonza
Copy link
Member

While developing new plugins, I noticed that once in a while some will not load correctly. After further investigation, it resulted that if the plugin relied on a plugin-type and the plugin-type had a filename that was alphanumerically higher than the plugin - the system reset will fail because the plugin-type will not be added before the plugin.

This PR makes sure that plugin-types are always activated before regular plugins; solving the above issue.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 92.894% when pulling 51f5351 on antgonza:min-fix-for-plugin-testing into e0428d5 on qiita-spots:dev.

Copy link
Contributor

@charles-cowart charles-cowart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Everything looks good. No changes requested.

@charles-cowart charles-cowart merged commit 2a341b5 into qiita-spots:dev Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants