-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes after 2022.04 #3199
fixes after 2022.04 #3199
Conversation
@@ -55,6 +55,26 @@ class Artifact(qdb.base.QiitaObject): | |||
""" | |||
_table = "artifact" | |||
|
|||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to iter over all Artifacts more often than before, thus this method.
@@ -79,17 +99,6 @@ def iter_by_visibility(cls, visibility): | |||
for a_id in qdb.sql_connection.TRN.execute_fetchflatten(): | |||
yield cls(a_id) | |||
|
|||
@classmethod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used anywhere in the code.
qdb.sql_connection.TRN.add( | ||
sql, [tuple(pt.id for a in all_artifacts | ||
for pt in a.prep_templates)]) | ||
# there are cases that an artifact would not be linked to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we have artifacts (like those generated by the sequencing processing pipeline) without prep/analysis linkages.
{% else %} | ||
<a href="https://github.com/biocore/qiita/commit/{{qiita_sha}}"> | ||
{% end %} | ||
<a href="https://github.com/qiita-spots/qiita/releases"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should point to the releases page vs. the sha
that is too dev oriented.
port = p_url.port | ||
except Exception: | ||
port = 22 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ssh connection is currently broken due to newer python, this fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good so far.
General improvements after deployment.