fixes after 2022.04 #3199
Merged
fixes after 2022.04 #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgonza
commented
May 12, 2022
| @@ -55,6 +55,26 @@ class Artifact(qdb.base.QiitaObject): | |||
| """ | |||
| _table = "artifact" | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
We need to iter over all Artifacts more often than before, thus this method.
| @@ -79,17 +99,6 @@ def iter_by_visibility(cls, visibility): | |||
| for a_id in qdb.sql_connection.TRN.execute_fetchflatten(): | |||
| yield cls(a_id) | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
This is not used anywhere in the code.
| qdb.sql_connection.TRN.add( | ||
| sql, [tuple(pt.id for a in all_artifacts | ||
| for pt in a.prep_templates)]) | ||
| # there are cases that an artifact would not be linked to a |
There was a problem hiding this comment.
Now we have artifacts (like those generated by the sequencing processing pipeline) without prep/analysis linkages.
| {% else %} | ||
| <a href="https://github.com/biocore/qiita/commit/{{qiita_sha}}"> | ||
| {% end %} | ||
| <a href="https://github.com/qiita-spots/qiita/releases"> |
There was a problem hiding this comment.
We should point to the releases page vs. the sha that is too dev oriented.
| port = p_url.port | ||
| except Exception: | ||
| port = 22 | ||
|
|
There was a problem hiding this comment.
The ssh connection is currently broken due to newer python, this fixes it.
charles-cowart
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General improvements after deployment.