allow artifact summary update #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-cowart
requested changes
Jun 16, 2022
| if isfile(fp): | ||
| remove(fp) | ||
| else: | ||
| rmtree(fp) |
There was a problem hiding this comment.
rmtree() can take a callback function to handle errors or ignore failures to delete. Just to confirm, is it better to just have it raise an Error here instead of using a handler or ignoring it?
There was a problem hiding this comment.
it has been fine so far ... but if you have specific examples of what to add and why, please let me know.
There was a problem hiding this comment.
True. I just realized path_cleaner() is using the same parameters. I was thinking it might be good to avoid an Error in that part of the code, but it hasn't caused issues so far, and I'd need to look deeper into it in order to provide a specific example.
charles-cowart
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to update artifact summaries via:
artifact_summary_post_request(user, artifact_id, force_creation=True)and while adding this, I realized that we were removing the current file if the file had the same name that the previous version.