Removing httpretty #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways an Authorization problem)
|
This PR is ready for review - however, tests will fail until qiita-spots/qiita#1862 is merged. |
|
@josenavas, could you let us know when tests pass? Thanks. |
|
Passed! |
| @@ -158,80 +132,69 @@ def test_patch_value_error(self): | |||
| # Add, replace or test | |||
| with self.assertRaises(ValueError): | |||
| self.tester.patch( | |||
| '/qiita_db/artifacts/1/filepaths/', 'add', '/html_summary/', | |||
| '/qiita_db/artifacts/1/', 'add', '/html_summary/', | |||
There was a problem hiding this comment.
So filepaths is not being tested anymore?
There was a problem hiding this comment.
The filepaths endpoint no longer exists. In any case, this is just checking the patch functionality of the qiita_client, so the only thing that I needed is an endpoint that allows patching.
|
1 question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the mock REST api using httpretty and uses the local installation of Qiita to test the plugin.
Currently I've only modified one test to check if it works as expected, I will modify the other ones once I know this works.