-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicated messages from ql.nprint when using the library with absl-py #425
Comments
I dont understand. So you want to create a PR for absl-py ? |
@xwings Sorry for not making it clear. I'd like to set up the logger so it does not propagate to the root logger by default to avoid double printing, i.e. diff --git i/qiling/utils.py w/qiling/utils.py
index 14373376..4b71c450 100644
--- i/qiling/utils.py
+++ w/qiling/utils.py
@@ -166,6 +166,7 @@ def ql_setup_logger(logger_name=None):
logger_name = 'qiling_%s' % _counter
logger = logging.getLogger(logger_name)
+ logger.propagate = False
logger.setLevel(logging.DEBUG)
return logger |
@ucgJhe what do you think |
since we don't use propagation mechanism in qiling for now, disable it should be fine. |
@kqyang a PR maybe ? |
kqyang
added a commit
to kqyang/qiling
that referenced
this issue
Aug 13, 2020
Done: #442. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See abseil/abseil-py#148 for details.
Here is a sample output:
One workaround suggested by the developer of absl-py is to set propagate to False by default. I can create a PR for the change if you are ok with it.
The text was updated successfully, but these errors were encountered: