Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macho load command 'LC_LOAD_WEAK_DYLIB' support #1133

Merged
merged 11 commits into from May 2, 2022

Conversation

profiles
Copy link

@profiles profiles commented Apr 21, 2022

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature update.
  • This PR introduces a new function/api for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@kabeor
Copy link
Member

kabeor commented Apr 30, 2022

@profiles Hello, plz rebase this pr to dev branch

@xwings xwings changed the base branch from master to dev May 2, 2022 14:59
@xwings
Copy link
Member

xwings commented May 2, 2022

@profiles after switching base, there is new conflict

@kabeor kabeor merged commit c4a046d into qilingframework:dev May 2, 2022
@kabeor
Copy link
Member

kabeor commented May 2, 2022

thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants