Fix ELF argv encoding #1303
Merged
Fix ELF argv encoding #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xwings
approved these changes
Jan 9, 2023
// gcc -fno-stack-protector -no-pie -m32 bof.c -o bof.bin
#include <stdio.h>
#include <string.h>
void never_called() {
puts("qiling power");
}
int fun(char *str) {
char buffer[20];
strcpy(buffer, str);
return 0;
}
int main(int argc, char *argv[]) {
fun(argv[1]);
return 0;
}from qiling import Qiling
from qiling.const import QL_VERBOSE
ql = Qiling(["./bof.bin", "A"*32 + "\x86\x91\x04\x08"], "/", verbose=QL_VERBOSE.DEFAULT)
ql.run()Platform: Here is the minimum test script i use to test this PR, and I found out that the output is different from the normal execution. The payload does nothing but simply overwrite saved-eip in stack with another function address for hijacking execution flow. qiling logstraceExpected output
trace log (verbose=DISASM)
Also, I noticed that trace log is some how incomplete, the function |
|
I followed the steps you described here, but got the expected result: The from qiling import Qiling
from qiling.const import QL_VERBOSE
ROOTFS = r'examples/rootfs/x86_linux'
TARGET = r'/bin/bof2'
ql = Qiling([fr'{ROOTFS}{TARGET}', 'A' * 32 + '\xb6\x91\x04\x08' + 'BBBB'], ROOTFS, verbose=QL_VERBOSE.DEFAULT)
ql.run()I tried executing this with both Qiling Linux rootfs and my own Linux root, and they both work (that is, display "qiling power" and then crash). So I am not sure there is a problem here; I guess you are using r2 analysis to show the disasm info, could it be the source for the problem..? As for your final comment about the addresses, I am not sure that I understand the problem. Note that |
|
nvm, i got it though. I think this PR is good to merge. |
kabeor
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed ELF argv encoding from "utf-8" to "latin" to avoid corruption of specially crafted command line arguments (more details in the fixed issue).
Fixes #1269