Fix __CreateFile implmentation to include access mask and creation disposition #1309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
The current implementation of
_CreateFile
for emulating thekernel32.dll$CreateFile
functions does not properly use the dwCreationDisposition flags or the access mask. This pr does not fully fix the issue, but _CreateFile now properly handles most access masks, and creation dispositions. The notable exception is GENERIC_WRITE, with no truncation and no create new file will return a handle that is writable. This is consistent with the current implementation, and while a bug, is likely only fixable by using os.open instead of open.