fixed get_ins_exclude_lib not handling multiple shared objects properly #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2023 15:03
…you want to filter history from multiple shared objects
…multiple shared objects properly
elicn
reviewed
Feb 26, 2023
… history functions to return capstone objects because they are nicer to look at than just integers (addresses)
elicn
approved these changes
Mar 5, 2023
| @@ -122,13 +132,13 @@ def get_mem_map_from_addr(self, ins: int) -> tuple: | |||
| # i sure hope theres not more than one map that contains the instruction lol | |||
| return mem_map[0] | |||
|
|
|||
| def get_regex_matching_exec_maps(self, libs: List) -> List: | |||
| def get_regex_matching_exec_maps(self, libs: List[str]) -> List: | |||
There was a problem hiding this comment.
It looks like libs should be of type Union[str, Collection[str]] as it accepts both options.
added 5 commits
March 6, 2023 17:24
… types, __hook_block is a class method now because it makes sense,
…or dealing with arm arch, and not accessing the ql.arch.disassember directly anymore
kabeor
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing
the current implementation doesnt handle the case where you want to exclude multiple shared objects. also added test cases to catch this bug