Skip to content

Commit

Permalink
[Fix/apc] typo in profiling
Browse files Browse the repository at this point in the history
Summary:
A typo makes it not using normalized keys in profiling deletion,
resulting in incorrect group stats. Does not affect production
correctness.

Test Plan: make fast_tests

Reviewers: mwilliams, myang

Reviewed By: myang

CC: ps, mwilliams, myang

Differential Revision: 353265
  • Loading branch information
qigao authored and macvicar committed Nov 29, 2011
1 parent ce78855 commit 4a43254
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/runtime/base/shared/shared_store_stats.cpp
Expand Up @@ -426,7 +426,7 @@ void SharedStoreStats::onDelete(StringData *key, SharedVariant *var,

if (RuntimeOption::EnableAPCSizeGroup) {
StatsMap::const_accessor cacc;
if (s_statsMap.find(cacc, (char*)key->data())) {
if (s_statsMap.find(cacc, normalizedKey)) {
SharedValueProfile *group = cacc->second;
group->removeFromGroup(&svpTemp);
if (noTTL) {
Expand Down

0 comments on commit 4a43254

Please sign in to comment.