Migrate to github actions #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
error info: error: unmappable character for encoding Cp1252. windows seems try to detect character encoding when scan non-ascii characters, but an incorrect encoding is determined. We explicitly set compile/compileTest/javadoc encoding to utf-8 to avoid this. Note: A one-shot config good enough is not found currently.
Xuanwo
reviewed
Nov 16, 2020
also remove travis-ci config.
Xuanwo
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make github actions run successfully, there are two issues just fixed:
javadoc generation with backward compatible option:
--no-module-directoriesDue to https://bugs.openjdk.java.net/browse/JDK-8196202 JDK 11 breaks
the search box in generated javadocs because module directories are
assumed.
This JDK bug is fixed in JDK 12, but until then we need to add
'--no-module-directories' to the javadoc options.
After JDK12, this option is been removed, so we should not add it then.
windows encoding
Fix build failure in windows caused by encoding
error info: error: unmappable character for encoding Cp1252.
windows seems try to detect character encoding when scan non-ascii
characters, but an incorrect encoding is determined.
We explicitly set compile/compileTest/javadoc encoding to utf-8 to avoid
this.