修复从 token 解析 bucket 的 bug & 完善下类型 & fix issue #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winddies
changed the title
lzfee0227
reviewed
Jun 30, 2020
Comment on lines
+131
to
+133
| } catch (e) { | ||
| this.onError(e) | ||
| } |
There was a problem hiding this comment.
这个异常应该不重新 throw 出去吗？ @nighca
src/utils.ts
Outdated
| @@ -273,7 +273,7 @@ interface PutPolicy { | |||
| export function getPutPolicy(token: string) { | |||
| const segments = token.split(':') | |||
| const ak = segments[0] | |||
added 2 commits
June 30, 2020 11:34
lzfee0227
reviewed
Jun 30, 2020
Comment on lines
+275
to
+277
| // token 构造的差异参考：https://github.com/qbox/product/blob/master/kodo/auths/UpToken.md#admin-uptoken-authorization | ||
| const ak = segments.length > 3 ? segments[1] : segments[0] | ||
| const putPolicy: PutPolicy = JSON.parse(urlSafeBase64Decode(segments[segments.length - 1])) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
* 完善下 observable 文件中的类型 * 增加 base64 编解码函数的导出 fix #455