Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QNServerConfigSynchronizer Token 野指针崩溃 #423

Open
lyandy opened this issue Jan 16, 2023 · 2 comments
Open

QNServerConfigSynchronizer Token 野指针崩溃 #423

lyandy opened this issue Jan 16, 2023 · 2 comments

Comments

@lyandy
Copy link

lyandy commented Jan 16, 2023

崩溃sentry堆栈：https://app-sentry.taou.com/share/issue/8c4977e7073c4e0996b1248f93025c37/

image

通过分析发现是 QNServerConfigSynchronizer赋值Token崩溃
image
进一步分析发现，Token全局静态变量，全局静态变量赋值，如果不加锁多线程下一样会出现野指针 over-release崩溃
image

其实这里的 Hosts 变量也一样，需要加锁，做多线程安全
This was referenced Jan 16, 2023
Closed
Open
@YangSen-qn
Copy link
Contributor

感谢您的反馈

@lyandy
Copy link
Author

lyandy commented Jan 17, 2023

感谢您的反馈

麻烦看一下我提交的pr，fix了此问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lyandy @YangSen-qn