Merge pull request #375 from qiniu/hotfix/header-key-name-valid

fix header isValidKeyName
qiniu · Jan 25, 2022 · 5221503 · 5221503
2 parents dd4b3d3 + 5e1711f
commit 5221503
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/Qiniu/Http/Header.php b/src/Qiniu/Http/Header.php
@@ -264,7 +264,7 @@ public function count()
      */
     private static function isValidKeyName($str)
     {
-        for ($i = 0; $i < count($str); $i += 1) {
+        for ($i = 0; $i < strlen($str); $i += 1) {
             if (!isset(self::$isTokenTable[$str[$i]])) {
                 return false;
             }

diff --git a/tests/Qiniu/Tests/HeaderTest.php b/tests/Qiniu/Tests/HeaderTest.php
@@ -40,6 +40,20 @@ public function testNormalizeKey()
         $this->assertEquals($actual, $except);
     }
 
+
+    public function testInvalidKeyName()
+    {
+        $except = array(
+            'a:x-test-1',
+        );
+
+        $actual = array_map(function ($str) {
+            return Header::normalizeKey($str);
+        }, $except);
+
+        $this->assertEquals($except, $actual);
+    }
+
     public function testGetRawData()
     {
         $header = new Header($this->heads);