Spec compliance: change num_required_* to required_num_* #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also maintain ability to parse old required_num_* attributes in order to maintain as much backwards compatibility as possible.
bmhowe23
requested review from
idavis,
minestarks and
swernli
as code owners
|
@microsoft-github-policy-service agree [company="NVIDIA"] |
|
@microsoft-github-policy-service agree company="NVIDIA" |
idavis
approved these changes
Oct 18, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #250, the Base Profile spec specifies that
required_num_qubitsandrequired_num_resultsmust be used in the entry point function. This change updates the pyqir project to use those attributes in all places. I think it also maintains ability to parse oldnum_required_*attributes in order to maintain as much backwards compatibility as possible, but please let me know if I've missed anything there.