Get building on LLVM 18.1 (...But not working) #278
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough work on upgrading to LLVM 18.1.6 (#224). This builds, but the tests definitely do not pass (some segfault, actually). So this should not be merged into
main
in its current state, but I'm putting this up if it saves someone some time.I built this with the following in
pyqir/
:(I did not use the PowerShell build script.)
Remaining Problems
If y'all are interested, I can continue working on this and get the tests to pass.
One thing that seems particularly nasty at the moment is how to handle
Builder.call()
. I can think of two options:Builder.call()
to also take aType
(looks like that already exists intypes.rs
). This is backwards incompatibleValue
to also hold anLLVMType
. (This may quickly become burdensome to support in future usecases, but it would probably be a simpler user-facing API)What do y'all think? And are there plans to upgrade LLVM at all?