Fix accumulated phase for rotations by 2 Pi #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix was missing from #163, which only addressed the special case for rotations by Pi and missing the corresponding special case for rotations by 2 Pi. This makes sure the phase of -1 is present for Rx/Ry by 2 Pi, and adds tests to confirm them.
11 tasks
idavis
approved these changes
May 21, 2024
swernli
added a commit
to microsoft/qsharp
that referenced
this pull request
May 21, 2024
This updates the revision of the sparse simulator used to pull in the fix from qir-alliance/qir-runner#173. The change also includes the results from `cargo update` to get dependent packages up the latest minor/rev version compatible with the repo.
github-merge-queue bot
pushed a commit
to microsoft/qsharp
that referenced
this pull request
May 24, 2024
This updates the revision of the sparse simulator used to pull in the fix from qir-alliance/qir-runner#173. The change also includes the results from `cargo update` to get dependent packages up the latest minor/rev version compatible with the repo.
swernli
added a commit
that referenced
this pull request
Jun 14, 2024
This follows up on the fix from #173, which inadvertantly introduced a global phase on Rx/Ry rotations by 0.0 (and odd increments of Pi). This avoids the problem by checking the other part of the matrix to determine if the phase is required rather than applying it unconditionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix was missing from #163, which only addressed the special case for rotations by Pi and missing the corresponding special case for rotations by 2 Pi. This makes sure the phase of -1 is present for Rx/Ry by 2 Pi, and adds tests to confirm them.