Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test values that were broken by Terra transpilation changes #54

Closed
wants to merge 1 commit into from

Conversation

kevinsung
Copy link

Fixes #52 .

The test was broken by Qiskit/qiskit#8552.

Note that this change itself is broken by Qiskit/qiskit#9026, so the test will need to be updated again for the version of Terra that includes that change. Perhaps this indicates that the test should be modified. Apparently, the output of the call

transpile(qc, FakeLima(), seed_transpiler=102442)

can change with new versions of Terra. We should also consider pinning the version of Terra used by mapomatic.

@kevinsung
Copy link
Author

In this PR I simply copied and pasted the values to make the tests pass. The values themselves still need to be manually checked for correctness (otherwise the test is pointless). @nonhermitian since you wrote this test and are more familiar with how mapomatic works I was hoping you could do that when you review this.

@nonhermitian
Copy link
Collaborator

This has been handled as part of #57

@kevinsung kevinsung deleted the fix-tests branch January 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test
2 participants